Add special "Start" button to Enrollment Flow views (CFM-428) #251
+79
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration views (CFM-428)
Ioannis
requested changes
Nov 20, 2024
| @@ -52,6 +52,49 @@ | |||
| <?= $this->element('subnavigation/supertitle') ?> | |||
| <?= $this->element('subnavigation/statusBadge') ?> | |||
| </div> | |||
|
|
|||
There was a problem hiding this comment.
Can you move this into its own element under the sub-navigation directory. Or if it could be used in other places under the element directory.
There was a problem hiding this comment.
I considered that, but I don't believe it will be used anywhere else - it's very much a one off. But, there's certainly no harm in moving it into its own element.
There was a problem hiding this comment.
Ok - I've improved this and made it more generic (in case we do find we want to reuse this idea). The new element is "upperButtons.php" and the css has been modified similarly.
Ioannis
approved these changes
Nov 21, 2024
arlen
changed the title
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.