Add special "Start" button to Enrollment Flow views (CFM-428) #251
+79
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration views (CFM-428)
Ioannis
requested changes
Nov 20, 2024
| @@ -52,6 +52,49 @@ | |||
| <?= $this->element('subnavigation/supertitle') ?> | |||
| <?= $this->element('subnavigation/statusBadge') ?> | |||
| </div> | |||
|
|
|||
There was a problem hiding this comment.
Can you move this into its own element under the sub-navigation directory. Or if it could be used in other places under the element directory.
There was a problem hiding this comment.
I considered that, but I don't believe it will be used anywhere else - it's very much a one off. But, there's certainly no harm in moving it into its own element.
There was a problem hiding this comment.
Ok - I've improved this and made it more generic (in case we do find we want to reuse this idea). The new element is "upperButtons.php" and the css has been modified similarly.
Ioannis
approved these changes
Nov 21, 2024
arlen
changed the title
Ioannis
pushed a commit
that referenced
this pull request
Dec 15, 2024
* Add special "Start" and "Copy" (flow url) buttons to Enrollment Flow configuration views (CFM-428) * Improve "Cannot copy" message for javascript clipboard (CFM-428) * Make upper buttons more generic (CFM-428) * Shorten test block for applying upper buttons (CFM-428) * De-emphasize "Copy URL" and move it to the left of "Start" (CFM-428) * Remove "Copy URL" button (CFM-428) * Trivial clean up to comment (CFM-428)
arlen
added a commit
that referenced
this pull request
Dec 19, 2024
* Initial implementation of Enrollment Flow infrastructure and Attribute Collector (CFM-31) * Miscellaneous Enrollment fixes (CFM-31) * Refactor EnrollmentFlow* files:setPermissions * Add top-level subnavigation to Enrollment Flow and Enrollment Flow Steps (CFM-31) (#166) * Add main-menu navigation for Petitions and Enrollments (CFM-31) * Add titles to Petition steps and buttons to the steps index (CFM-31) (#173) * Simplify end-user Petition views (CFM-31) (#175) * Subnavigation fix for Enrollment Flow steps (CFM-31) (#177) * Post-rebase vs. develop corrections (CFM-31) * Update AttributeCollectors permissions definition (CFM-31) * fix EnrollmetFlow and EnrollmentFlowSteps fields * Fix EnrollmentAttributes fiels * lookupPersonByLogin vs lookupPersonForLogin fix * Render Enrollment Attributes edit/add/view in a modal * remove duplicate field * Correct test for $rowActions post-rebase. (CFM-31) * feature-cfm31-subnavigation (#217) * Group to tabs element * enrollment flows tabs * Person to tabs * Missing tabs code * Improve Status badge. * Typos * Core code should not depend on Plugins for subnavigation * simplify code * Move subnavigation import to a php partial * Remove obsolete files.Add support for custom actions * Active navigation tab form deep associated model * fix active navigation tab first level * Fixed deep associations * Fix tab counter for all use cases * Fix active tabs everywhere. * fix depth calculation * Fix EnrollmentFlow broken start view. Fix petitions view. * Fix dispatch View to use the new FieldHelper.php * Fix missing curly brach error * Improve Form global edit mode handling * Fix petition view issue * Add filter block for Enrollment Flows and Petitions * Filter Petitions by COU * Make dispatch view editable * Add petition "start" action to $isActivePetition boolean in default.php (CFM-31) (#218) * Add enrollment attribute view should redirect to "self" (CFM-31) (#219) * Remove deprecated subnavigation config (CFM-31) (#220) * fix iframe flash message rendering * Simple fix for h1 title (CFM-31) (#221) * Ensure a title exists on Petition start, dispatch, and resume (CFM-31) (#222) * Remove unnecessary top-link from Enrollment Flow properties (CFM-31) (#223) * fix deep nested navigation tab id calculation * Add TabHelper missing dependency * Refactor Enrollment Attributes Add/Edit view (#224) * Fix wrong url id harvest (#225) * Set petition titles (Enrollment Flow name, Flow Step description) in dispatch view (CFM-31) (#227) * fix subnavigation issues (#228) * Cleanup to subnavigation and titling (CFM-31) (#229) * Cleanup to subnavigation and titling (CFM-31) * Trivial cleanup (CFM-31) * More trivial cleanup (CFM-31) * Even more trivial cleanup (CFM-31) * Initial implementation of BasicAttributeCollector (CFM-415) (#231) Co-authored-by: Benn Oshrin <boshrin@users.noreply.github.com> * Subnavigation fixes (#230) * Fix field config for select elements in Pipelines and Message Templates (CFM-31) (#234) * fix FieldHelper.php fieldType missing fieldSelectOptions issue * Fix tab rendering for EnrollmentFlow plugins (#235) * Fix tab rendering for EnrollmentFlow plugins * Improve getLayout trait * fix enrollment attributes add/edit view title * Conditionally include a 'Cancel' button next to 'Save' (CFM-31) (#236) * Fix use case:Plugin.Hierarchy deep nested when no hasMany association. * Check for hasMany associations before rendering a tab * Fix misspelled variable * Fix Petition Attributes Form rendering (#241) * Fix Petition Attributes Form rendering * populate autoview vars in the petition attribute collection view * AttributeCollectors/dispatch.inc fix fields configurations. * Add field description. Add FieldHelper support to Attribute selection view. * Fix field sorting.Fix type dropdowns. * Initial theme commit for Enrollment Flow Attribute Collector (CFM-31) (#242) * Update of attribute collector list-element class names for better consistency (CFM-31) (#243) * Fix Attribute Collectors dispatch view dependency data * Select attribute fields by css class name (CFM-31) (#245) * Initial commit of Mostly Static Pages (CFM-62), InvitationAccepter (CFM-334) and UpsertTrait (CFM-423) * Initial implementation of Identifier Collector Enroller (CFM-111) * Update attribute collector CSS selectors to reflect updated DOM class output (CFM-31) (#247) * First pass at cleaning up Petition view (CFM-31) (#246) * First pass at cleaning up Petition view (CFM-31) * Remove status read-only field (CFM-31) * Add fields to Petition Information (CFM-31) * Reformat Petition Information view (CFM-31) * Add Petition History Records output to petition view (CFM-31) * Further refinement to the layout of the Petition view (CFM-31) * Add Resume top-link to Petition view (CFM-31) * Add support for attribute collection fieldsets (#244) * Add support for attribute collection fieldsets * Attribute Collection view FieldGroups * fix fieldst hover css * Refactored required and permitted calculations.Moved attribute collections parts to elements. * Add FieldHelper support for textarea. Refactored fieldset-group. * fix enumerations and locales * improvements * Remove duplicate element * Improve classes in element * cleanup * Switch to Material Symbols (CFM-404) (#248) * Style Basic Attribute Collector and ensure that names and telephone numbers grow and shrink based on permitted fields. (CFM-426) (#249) * Fix flash error construction.name type_id field is required * method parameters must not come before the required ones as of php 8.1 * cfm-31_people-picker (#250) * Sponsors+Managers to people picker * autocomplete default label enable hiding * Internationalize the fallback element text * Fix unable to update picker field * input property value to have the id on update and not only the full name * Fix method signature * Add special "Start" button to Enrollment Flow views (CFM-428) (#251) * Add special "Start" and "Copy" (flow url) buttons to Enrollment Flow configuration views (CFM-428) * Improve "Cannot copy" message for javascript clipboard (CFM-428) * Make upper buttons more generic (CFM-428) * Shorten test block for applying upper buttons (CFM-428) * De-emphasize "Copy URL" and move it to the left of "Start" (CFM-428) * Remove "Copy URL" button (CFM-428) * Trivial clean up to comment (CFM-428) * Small stylistic improvements to Enrollment Flow dispatch and start views and to Enrollment Flow Steps index (CFM-428) (#253) * Improve Petition index and add a label prefix config for index view (CFM-428) (#252) * Improve Petition index and add a label prefix config for index view (CFM-428) * Swap column order for enrollee and enrollment flow (CFM-428) * Allow null coid for AutoViewVarsTrait (nojira) * Make Add drop-down menu a panel. Also fix welcome message and main menu visibility. (CFM-321) (#256) * Initial commit of Email Verifier Enroller Plugin (CFM-333) * Additional commit for CFM-333 * Implement finalization tasks (CFM-31) * Provide better evaluations in upperButtons start enrollment flow link (CFM-428) (#257) * fix rebase remaining message * feature-cfm31 post rebase fixes #1 (#262) * Fix Copy value button label post-rebase (CFM-31) * Fix email address top-link post-rebase (CFM-31) * Fix URLs missing associations. Improving mvea tile render on error. * Add UrlsTable missing changes. * feature-cfm31 post rebase fixes2 (#264) * Fix resume page top menu unique id (CFM-31) * Fix javascript i18n text references in people picker post rebase (CFM-31) * Fix JavaScript "Global visit link" text reference in URL MVEA post rebase (CFM-31) * Update "deleted" action post-rebase (CFM-31) --------- Co-authored-by: Benn Oshrin <boshrin@users.noreply.github.com> Co-authored-by: Arlen Johnson <arlen@sphericalcowgroup.com> Co-authored-by: benno <benno@sphericalcowgroup.com>
arlen
added a commit
to arlen/registry
that referenced
this pull request
Dec 19, 2024
…ge#251) * Add special "Start" and "Copy" (flow url) buttons to Enrollment Flow configuration views (CFM-428) * Improve "Cannot copy" message for javascript clipboard (CFM-428) * Make upper buttons more generic (CFM-428) * Shorten test block for applying upper buttons (CFM-428) * De-emphasize "Copy URL" and move it to the left of "Start" (CFM-428) * Remove "Copy URL" button (CFM-428) * Trivial clean up to comment (CFM-428)
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.